Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • NIRISS testing is being done using awesimsoss NIRISS/SOSS simulations of K2-141 (which has a short transit duration, hence the selection). Care must be taken as this is the first end-to-end simulation of awesimsoss (which is under active development). In-progress notebooks of each stage testing can be found here.
  • MIRI testing is being done using MIRISim simulations of MIRI/LRS.
  • NIRCam testing is being done using Mirage simulations of imaging and grism time series (350 frames of 5 groups, i.e. 70 exposures) of a modified version (deeper transit) of WASP-79b. Notebooks for the testing are available here.
  • NIRSpec testing is being done on CV3 data.

...

todotodo
Pipeline stepNIRISS statusNIRISS commentsNIRCam statusNIRCam commentsMIRI statusMIRI commentsNIRSpec statusNIRSpec comments
group_scale

Status
colourGreen
titleDone

The step is supossed to do nothing for NIRISS/SOSS (here, a group = 1 frame). Indeed, nothing changes when running this step, except for the length of the ASDF element in the HDU list object, which is normal.

todo
Status
title
colourGreen
titleDONE

Runs well without a crash with the run() and call() commands for both imaging and spectroscopy TS. An CRDS - ERROR - Error determining best reference for 'pars-groupscalestep' = Unknown reference type 'pars-groupscalestep'. This seems to be a warning, rather than an error. N/A

Status
todo
colourGreen
titleDONE

Runs without issue.
dq_init

Status
colourGreen
titleDone

This step correctly initializes the data-quality flags, as it is supposed to do, according to the reference mask in CRDS.

Status
todo
colourGreen
titleDONE

Runs well without a crash with the run() and call() commands for both imaging and spectroscopy TS. The data quality flags are initialized correctly. This step has sufficiently been tested by unit testing.

Status
colourGreen
titleDONE

(high-level test)

status
Status
colourGreen
todo
titleDONE

Runs without issue.
saturation

Status
colourGreen
titleDone

This step does what is expected to do: it captures saturated pixels and flags them in the GROUPDQ masks. The simulations used for this validation had saturated pixels and they were correctly identified (flagged) by the pipeline.

Status
todo
colourGreen
titleDONE

Runs well without a crash with the run() and call() commands for both imaging and spectroscopy TS. Saturated pixels are identified and flagged in the GQ masks correctly. This step has sufficiently been tested by unit testing.

Status
colourGreen
titledone

(done for imager. only high - level )check for LRS.

Status
todo
colourGreen
titleDONE

Runs without issue.
superbias

Status
colourGreen
titleDone

Tested my own bias substraction using reference files and got exact same results.

Status
todo
colourGreen
titleDONE

Runs well without a crash with the run() and call() commands for both imaging and spectroscopy TS. This step has sufficiently been tested by unit testing.N/A

Status
todo
colourGreen
titleDONE

Runs without issue.
resetN/A
N/A

Status
colourGreen
titleDONE

This was tested on a TSO imaging file separately since this step does not currently run by default. The test passed with no issues.N/A
linearity

Status
colourGreen
titleDone

Tested linearity correction using reference files and got exact same results.

Status
todo
colourGreen
titleDONE

Runs well without a crash with the run() and call() commands for both imaging and spectroscopy TS. The step performs what is expected and has sufficiently been tested by unit testing.

Status
todo
colourGreen
titleDONE

sufficiently covered by unit testing. 

Status
todo
colourGreen
titleDONE

Runs without issue.
rscdN/A
N/A

Status
colourGreen
titleDONE

Step currently flags frames in integrations higher than the first as 'DO_NOT_USE' in the groupdq array. This has been tested successfully.N/A
dark_current

Status
colourGreen
titleDone

Dark frames perform expected corrections on the data.

Status
colourGreen
titletodo

Status
titletodo

Status
title

doNE

Runs well without a crash with the run() and call() commands for both imaging and spectroscopy TS. Dark subtraction works well.

Status
colourGreen
titleDONE

sufficiently covered by unit testing

Status
colourGreen
titleDONE

Runs without issue.
refpix

Status
colourGreen
titleDone

Currently, does not do anything to NIRISS/SOSS simulations, as reference pixels there are set to zero. When injecting a fake strain of reference pixels got some deviations that most likely have to do with DMS-detector frame rotations.

Status
todo
colourGreen
titleDONE

Runs well without a crash with the run() and call() commands for both imaging and spectroscopy TS. The step performs what is supposed to do and has sufficiently been tested by unit testing.

Still, I find this step to correct much less for subarrays (i.e. using half of the reference pixels) compared to a subtraction of the median value. This is not a suggestion to improve this for exoplanets, as the 1d cbc spectral extraction would do a better correction. Would be good for the imaging data though.

Status
colourGreen
titleDONE

This step is sufficiently tested in unit tests. It is skipped for MIRI subarray data so only applies to FULL array imaging TSOs, and note that MIRISim's implementation of Refpix is different from the pipeline step, so may give unexpected results. 

Status
todo
colourGreen
titleDONE


Runs without issue.
jump

Status
colourGreen
titleDone

Step produced no errors. However, currently detecting more jumps than it should — will revisit once some errors on the SOSS simulator are addressed (see below).

Status
todo
colourGreen
titleDONE

Runs without a crash, but identifies too many pixels as cosmic rays or bad with the default threshold of 4 sigma. Results improve if the threshold is increased to >15 sigma.

NOTE: This step names files 'jump', i.e. without the root 'step'. This differs to all of the remaining steps in stage 1. 

Status
colourGreen
titleDONE

high level testing is done. Inserted cosmic rays of varying strengths were detected (based on threshold) and flagged neighboring pixels (based on level above background)

Status
todo
colourGreen
titleDONE

Runs without issue.
ramp_fitting

Status
colourGreen
titleDone

The pipeline was tested against an OLS ramp fit, and pipeline does exactly as intended.

Status
colourYellowGreen
titleONGOING

produced rateints with 7.5 and independent linear fits; substantial difference in a subset of data.

Status
titletodo

Status
title

DONE

Runs well without a crash with the run() and call() commands for both imaging and spectroscopy TS. Ramp fitting (including OLS) has sufficiently been tested by unit testing and performs as expected. The run() command accepts weighting = "unweighted", despite the optimal is the only option and produces different results. The call() command has no options for weighting.

Status
colourGreen
titleDONE

Well covered by unit tests. May be a candidate for more detailed testing when time.

Status
colourGreen
titleDONE

Runs without issue.
gain_scale

Status
colourGreen
titleDone

This step only applies to NIRSpec data. Because no GAINFACT is found in the headers, this step is properly skipped by the pipeline.

Status
todo
colourGreen
titleDONE

Only applies to NIRSpec and skipped for NIRCam.

Status
colourGreen
titleDONE

Documentation states 'This currently only applies to NIRSpec exposures that are read out using a subarray pattern, in which case a gain setting of 2 is used instead of the standard setting of 1.' This step is properly skipped for MIRI data.

Status
todo
colourGreen
titleDONE

Runs without issue. 










Extended comments by instrument branch:

  • NIRISS: For the jump detection algorithm, the pipeline seems to be detecting a large fraction of jumps (~20% per integration). This is most likely due to a mismatch between reference files used to generate the simulations and the ones used to reduce the data, which ultimately leads to badly calculated errorbars, which might be giving rise to bad jumps. Will re-check this step once this is solved by the simulator, but the jump step seems to be doing what is intended to doapparently a known issue in other instruments as well, and is due to aggresive parameters in the reference files. These will need to be calibrated with on-sky data.
  • NIRCam
  • MIRI:
  • NIRSpec:  Build 7.5: The only NIRSpec Level 1 entry for DMS Build 7.5 is that all steps are verified to run without issues. NIRSpec does not have specific validation tests for Level 1 as this pipeline is common to all instruments and there are several tests already included within the pipeline code that have been verified previously by the instrument teams.

Stage 2: Spectroscopic processing TSO testing

todo

todo
Pipeline stepNIRISS statusNIRISS commentsNIRCam statusNIRCam commentsMIRI statusMIRI commentsNIRSpec statusNIRSpec comments
assign_wcs

Status
colourGreen
titleDone

Assign WCS indeed adds information to the ASDF name of the files. Tested that ranges of the WCS information made sense.

Status
todo
colourGreen
titleDONE

Runs without a crash and assigns WCS correctly.

Status
ONGOING
colourYellowGreen
titleDONE

done

Status
todo
colourGreen
titleDone

Build 7.5: Though we do not have a validation test, this is presumably ok since FS passes the test.

This test is not directly performed for BOTS since we do not have ESA intermediary products to compare against.  

Image AddedJP-1577 - Assign_wcs in spec 2 passes validation test OPEN

extract_2d

Status
colourGreen
titleDone

This step is not supported for NIRISS/SOSS, and indeed running this steps shows the "not-supported" message. Still, saves an output equal to the input.

Status
colourGreen
titletodo

Status
titletodo

doNE

Runs without a crash and extracts 2d spectra.

Status
colourGreen
titleDONE

n/a

Status
colourGreen
titleDone

Build 7.5: Though at present we do not have a validation test, this is presumably ok since FS passes the test.

Image AddedJP-1578 - Extract_2d step in spec2 passes the validation test OPEN

Status
title
flat_field

Status
todo
colourGreen
titleDone

Flat field is correctly applied to NIRISS/SOSS data. 

Status
todo
colourGreen
titledoNE

Runs without a crash and performs flat field correction.

Status
colourYellowGreen
titleONGOINGDONE

done for LRS B7.5, 7.6, 7.7

status
Status
colourGreen
titletodoDone

Build 7.5: Failed current validation test  passes for NRS2, but fails for NRS1:  Validated/verified


JP-1071 -NIRSpec: flat_field calspec2 step failing validation for FS ALLSLITS, BOTS, and MOS data OPEN

  • 31/Aug/20 BOTS component has been fixed and delivered


srctype

Status
todo
colourtitleGreen
titleDone

As stated in the documentation, TSO always defines SRCTYPE to POINT. The pipeline indeed does this for NIRISS/SOSS TSO data.

Status
todo
colourGreen
titleDONE

Runs without a crash. SRCTYPE correctly set to POINT.

Status
titletodo


Status
colourGreen
titletodoDONE

Build 7.5:   

Validated/verified

Logic is not correct, always defaults to POINT, even when provided EXTENDEDnow correct

JP-1576 - source_type logic in spec2 is not correct for NIRSpec FS and MOS modes OPEN  CLOSED

photom

Status
colourGreen
titletodo

Status
titletodo

Status
titletodo

Status
title

Done

Photometric calibration is performed according to the NIRISS reference files.

Status
colourGreen
titleDONE

Runs without a crash and performs as expected.

Status
colourGreen
titleDONE

done for LRS B7.5, 7.6, 7.7

Status
colourGreen
titleDONE

Build 7.5: N/A 

tso_photometry is skipped for NIRSpec. 

Jul 2020: Logic for the output units was coded in NPTT and tested. All modes passed.

extract_1d

Status
colourRed
titleDone

This step currently extracts a big chunk of the whole subarray as a spectrum, which produced order overlap, which makes this step produce an unusable product for science right now. An algorithm is in development for this step. For details, see 

Jira
serverSTScI JIRA
serverIdaac911eb-9c55-3f14-8368-77b436fb6dc2
keyJP-201
.

Status
colourGreen
titleDONE

Runs without a crash and extracts spectra. Still need to enable column-by-column background subtraction with a Jira ticked issued 

Jira
serverSTScI JIRA
serverIdaac911eb-9c55-3f14-8368-77b436fb6dc2
keyJP-1478todo

Status
todo
colourGreen
titleDONE

done for LRS up to B7.7

Status
titletodo

Build 7.5:                methodology needs to be vetted by TSOWG

This step is currently crashing with BOTS data; additional comments pending

Extended comments by instrument branch:

  • NIRISS:
  • NIRCam
  • MIRI:
  • NIRSpec:   Build 7.5: general stage 2 (spec2) BOTS comment:  verified BOTS (runs without issues and skips the correct steps)

Stage 2: Image Processing TSO testing

Pipeline stepNIRISS statusNIRISS commentsNIRCam statusNIRCam commentsMIRI statusMIRI commentsNIRSpec statusNIRSpec comments
assign_wcsN/A

Status
todo
colourGreen
titleDONE

Runs without a crash and assigns WCS correctly.

Status
titletodo

have successfully run imaging TSO simulations through Image2 and TSO3 but no notebooks yet for individual steps. high level checks looked good.

N/A


flat_field

N/A


Status
todo
colourGreen
titleDONE

Runs without a crash and performs flat field correction.

Status
titletodo


N/A


photom

N/A


Status
todo
colourGreen
titleDONE

Runs without a crash and performs as expected.

Status
titletodo


N/A


Extended comments by instrument branch:

...

Stage 3: Time-Series Observations (TSO) Processing testing

Pipeline stepNIRISS statusNIRISS commentsNIRCam statusNIRCam commentsMIRI statusMIRI commentsNIRSpec statusNIRSpec comments
outlier_detection

Status
colourGreen
title

Done

Testing and validation done. Found some problems both with the documentation (

Jira
serverSTScI JIRA
serverIdaac911eb-9c55-3f14-8368-77b436fb6dc2
keyJP-1647
) and with the effectiveness of the algorithm itself. On this latter point, the algorithm marks as outliers points that are predominantly on the edges of the SOSS profile (
Jira
serverSTScI JIRA
serverIdaac911eb-9c55-3f14-8368-77b436fb6dc2
keyJP-1654
). The algorithm also doesn't use time-series information at all, and only uses the median image to catch outliers (
Jira
serverSTScI JIRA
serverIdaac911eb-9c55-3f14-8368-77b436fb6dc2
keyJP-1655
). In my opinion, algorithm currently not optimal for NIRISS/SOSS TSOs at least.

Status
colourGreen
titleDONE

todo Statustitletodo


Status
titletodo


Status
titletodo

Build 7.5: Validation test needs to be written.  


tso_photometry

N/A


Status
colourGreen
title

todo

DONE

Runs without a crash and performs as expected.

Status
titletodo

have successfully run TSO imaging simulations through Image2 and TSO3 but no notebooks yet for individual steps. high level checks looked good.

Status
colourGreen
title

todo

DONE

Status
titletodo

N/A

tso_photometry is not performed by the pipeline for spectroscopy (NIRSpec). 
extract_1d

Status
colourRed
title

Done

This step currently extracts a big chunk of the whole subarray as a spectrum, which produced order overlap, which makes this step produce an unusable product for science right now. An algorithm is in development for this step. For details, see 

Jira
serverSTScI JIRA
serverIdaac911eb-9c55-3f14-8368-77b436fb6dc2
keyJP-201
.

Status
colourGreen
titleDONE

Runs without a crash and extracts spectra. Still need to enable column-by-column background subtraction with a Jira ticked issued 

Jira
serverSTScI JIRA
serverIdaac911eb-9c55-3f14-8368-77b436fb6dc2
keyJP-1478

todo Statustitletodo

Status
titletodo


Status
titletodo

Build 7.5: Validation test needs to be written.  Sept 2019: For now, use the same test as for spec2.  

Image AddedJP-1728 - NIRSpec extract_1d testing OPEN

Image AddedJP-1729 - labeling of NIRSpec BOTS integrations OPENThe level 3 "x1dints" product for NIRSpec BOTS data contains separate extensions for each integration and detector obtained in the exposure.  Currently, there is no obvious way to distinguish between each extension in terms of its corresponding detector and integration, which is necessary in order for a user to be able to combine the data on both detectors for a given integration. 


white_light

Status
titletodo


Status
colourGreen
title

DONE

Runs without a crash. Jira ticket issued for defining min/max wavelength for white light curve: 

Jira
serverSTScI JIRA
serverIdaac911eb-9c55-3f14-8368-77b436fb6dc2
keyJP-1469

todo

Status
titletodo


Status
titletodo

Build 7.5: Sept 2019: Need to design tests; start with verification


Extended comments by instrument branch:

...