Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Pipeline stepNIRISS statusNIRISS commentsNIRCam statusNIRCam commentsMIRI statusMIRI commentsNIRSpec statusNIRSpec comments
group_scale

Status
colourGreen
titleDone

The step is supossed to do nothing for NIRISS/SOSS (here, a group = 1 frame). Indeed, nothing changes when running this step, except for the length of the ASDF element in the HDU list object, which is normal.

Status
colourGreen
titleDONE

Runs well without a crash with the run() and call() commands for both imaging and spectroscopy TS. An CRDS - ERROR - Error determining best reference for 'pars-groupscalestep' = Unknown reference type 'pars-groupscalestep'. This seems to be a warning, rather than an error. N/A

Status
titletodo


dq_init

Status
colourGreen
titleDone

This step correctly initializes the data-quality flags, as it is supposed to do, according to the reference mask in CRDS.

Status
colourGreen
titleDONE

Runs well without a crash with the run() and call() commands for both imaging and spectroscopy TS. The data quality flags are initialized correctly. This step has sufficiently been tested by unit testing.

Status
colourGreen
titleDONE


Status
titletodo


saturation

Status
colourGreen
titleDone

This step does what is expected to do: it captures saturated pixels and flags them in the GROUPDQ masks. The simulations used for this validation had saturated pixels and they were correctly identified (flagged) by the pipeline.

Status
colourGreen
titleDONE

Runs well without a crash with the run() and call() commands for both imaging and spectroscopy TS. Saturated pixels are identified and flagged in the GQ masks correctly. This step has sufficiently been tested by unit testing.

Status
colourGreen
titledone

done for imager. only high level check for LRS.

Status
titletodo


superbias

Status
colourGreen
titleDone

Tested my own bias substraction using reference files and got exact same results.

Status
colourGreen
titleDONE

Runs well without a crash with the run() and call() commands for both imaging and spectroscopy TS. This step has sufficiently been tested by unit testing.N/A

Status
titletodo


resetN/A
N/A

Status
colourGreen
titleDONE

This was tested on a TSO imaging file separately since this step does not currently run by default. The test passed with no issues.N/A
linearity

Status
colourGreen
titleDone

Tested linearity correction using reference files and got exact same results.

Status
colourGreen
titleDONE

Runs well without a crash with the run() and call() commands for both imaging and spectroscopy TS. The step performs what is expected and has sufficiently been tested by unit testing.

Status
colourGreen
titleDONE

sufficiently covered by unit testing. 

Status
titletodo


rscdN/A
N/A

Status
colourGreen
titleDONE

Step currently flags frames in integrations higher than the first as 'DO_NOT_USE' in the groupdq array. This has been tested successfully.N/A
dark_current

Status
colourGreen
titleDone

Dark frames perform expected corrections on the data.

Status
colourGreen
titledoNE

Runs well without a crash with the run() and call() commands for both imaging and spectroscopy TS. Dark subtraction works well.

Status
colourGreen
titleDONE

sufficiently covered by unit testing

Status
titletodo


refpix

Status
colourGreen
titleDone

Currently, does not do anything to NIRISS/SOSS simulations, as reference pixels there are set to zero. When injecting a fake strain of reference pixels got some deviations that most likely have to do with DMS-detector frame rotations.

Status
colourGreen
titleDONE

Runs well without a crash with the run() and call() commands for both imaging and spectroscopy TS. The step performs what is supposed to do and has sufficiently been tested by unit testing.

Still, I find this step to correct much less for subarrays (i.e. using half of the reference pixels) compared to a subtraction of the median value. This is not a suggestion to improve this for exoplanets, as the 1d cbc spectral extraction would do a better correction. Would be good for the imaging data though.

Status
colourGreen
titleDONE

This step is sufficiently tested in unit tests. It is skipped for MIRI subarray data so only applies to FULL array imaging TSOs, and note that MIRISim's implementation of Refpix is different from the pipeline step, so may give unexpected results. 

Status
titletodo



jump

Status
colourGreen
titleDone

Step produced no errors. However, currently detecting more jumps than it should — will revisit once some errors on the SOSS simulator are addressed (see below).

Status
colourGreen
titleDONE

Runs without a crash, but identifies too many pixels as cosmic rays or bad with the default threshold of 4 sigma. Results improve if the threshold is increased to >50 >15 sigma.

NOTE: This step names files 'jump', i.e. without the root 'step'. This differs to all of the remaining steps in stage 1. 

Status
colourGreen
titleDONE

high level testing is done. Inserted cosmic rays of varying strengths were detected (based on threshold) and flagged neighboring pixels (based on level above background)

Status
titletodo


ramp_fitting

Status
colourGreen
titleDone

The pipeline was tested against an OLS ramp fit, and pipeline does exactly as intended.

Status
colourGreen
titleDONE

Runs well without a crash with the run() and call() commands for both imaging and spectroscopy TS. Ramp fitting (including OLS) has sufficiently been tested by unit testing and performs as expected. The run() command accepts weighting = "unweighted", despite the optimal is the only option and produces different results. The call() command has no options for weighting.

Status
colourGreen
titleDONE

Well covered by unit tests. May be a candidate for more detailed testing when time.

Status
titletodo


gain_scale

Status
colourGreen
titleDone

This step only applies to NIRSpec data. Because no GAINFACT is found in the headers, this step is properly skipped by the pipeline.

Status
colourGreen
titleDONE

Only applies to NIRSpec and skipped for NIRCam.

Status
colourGreen
titleDONE

Documentation states 'This currently only applies to NIRSpec exposures that are read out using a subarray pattern, in which case a gain setting of 2 is used instead of the standard setting of 1.' This step is properly skipped for MIRI data.

Status
titletodo











...

Pipeline stepNIRISS statusNIRISS commentsNIRCam statusNIRCam commentsMIRI statusMIRI commentsNIRSpec statusNIRSpec comments
assign_wcsN/A

Status
todo
colourGreen
titleDONE

Runs without a crash and assigns WCS correctly.

Status
titletodo

have successfully run imaging TSO simulations through Image2 and TSO3 but no notebooks yet for individual steps. high level checks looked good.

N/A


flat_field

N/A


Status
todo
colourGreen
titleDONE

Runs without a crash and performs flat field correction.

Status
titletodo


N/A


photom

N/A


Status
todo
colourGreen
titleDONE

Runs without a crash and performs as expected.

Status
titletodo


N/A


Extended comments by instrument branch:

...

Pipeline stepNIRISS statusNIRISS commentsNIRCam statusNIRCam commentsMIRI statusMIRI commentsNIRSpec statusNIRSpec comments
outlier_detection

Status
colourGreen
titleDone

Testing and validation done. Found some problems both with the documentation (

Jira
serverSTScI JIRA
serverIdaac911eb-9c55-3f14-8368-77b436fb6dc2
keyJP-1647
) and with the effectiveness of the algorithm itself. On this latter point, the algorithm marks as outliers points that are predominantly on the edges of the SOSS profile (
Jira
serverSTScI JIRA
serverIdaac911eb-9c55-3f14-8368-77b436fb6dc2
keyJP-1654
). The algorithm also doesn't use time-series information at all, and only uses the median image to catch outliers (
Jira
serverSTScI JIRA
serverIdaac911eb-9c55-3f14-8368-77b436fb6dc2
keyJP-1655
). In my opinion, algorithm currently not optimal for NIRISS/SOSS TSOs at least.

Status
colourGreen
titleDONE


Status
titletodo


Status
titletodo


tso_photometry

N/A


Status
titlecolourtodoGreen
Status
titleDONE

Runs without a crash and performs as expected.

Status
titletodo

have successfully run TSO imaging simulations through Image2 and TSO3 but no notebooks yet for individual steps. high level checks looked good.

Status
titletodo


extract_1d

Status
colourRed
titleDone

This step currently extracts a big chunk of the whole subarray as a spectrum, which produced order overlap, which makes this step produce an unusable product for science right now. An algorithm is in development for this step. For details, see 

Jira
serverSTScI JIRA
serverIdaac911eb-9c55-3f14-8368-77b436fb6dc2
keyJP-201
.

Status
colourGreen
titleDONE

Runs without a crash and extracts spectra. Still need to enable column-by-column background subtraction with a Jira ticked issued 

Jira
serverSTScI JIRA
serverIdaac911eb-9c55-3f14-8368-77b436fb6dc2
keyJP-1478todo

Status
titletodo


Status
titletodo


white_light

Status
titletodo


Status
colourGreen
titleDONE

Runs without a crash. Jira ticket issued for defining min/max wavelength for white light curve: 

Jira
serverSTScI JIRA
serverIdaac911eb-9c55-3f14-8368-77b436fb6dc2
keyJP-1469

Status
titletodo


Status
titletodo


...