You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 35 Next »

One of the main tasks of the TSO WG on FY2020 is to perform testing of the steps made by the JWST Calibration Pipeline for TSO-like data. This tracking sheet contains all the information regarding pipeline testing by the members of the TSO WG. Nestor Espinoza and Sarah Kendrew will be populating this page heavily in the weeks of July 20 and 27, 2020, for NIRISS and MIRI TSO testing, respectively. Nikolay Nikolov and Tony Keyes will be populating at their own pace for NIRCam and NIRSpec, respectively.

General guidelines for Pipeline Testing

  1. Please, test every step identified below. If for some reason you don't have time to test a step, let Nestor Espinoza and Sarah Kendrew know.
  2. Use the comments in the tables to post brief comments about the status of that testing step (think of it as a quick overview for others to know what is going on). For extended commentary, or details on how you performed the testing, use the text below the tables.
  3. If a bug is found, please report it in Jira as a "Bug" Jira ticket. Please copy the links to those tickets in the table below under the comments.
  4. For algorithm improvements/enhancements, please file an "Improvement" Jira ticket. Please copy the links to those tickets in the table below under the comments.

 In general, if bugs are found, the best would be to discuss them first in one of our meetings before going ahead and submitting them (unless this is high-priority, in which case we could schedule a special meeting for this). This is left at the discretion of each TSO WG member.

General comments

Before jumping to read the below table, some important comments to keep in mind while reading them:

  • NIRISS testing is being done using awesimsoss NIRISS/SOSS simulations of K2-141 (which has a short transit duration, hence the selection). Care must be taken as this is the first end-to-end simulation of awesimsoss (which is under active development). In-progress notebooks of each stage testing can be found here.
  • MIRI testing is being done using MIRISim simulations of MIRI/LRS.
  • NIRCam testing is being done using Mirage simulations.
  • NIRSpec testing is being done on CV3 data.

Stage 1: Detector Processing TSO testing

Pipeline stepNIRISS statusNIRISS commentsNIRCam statusNIRCam commentsMIRI statusMIRI commentsNIRSpec statusNIRSpec comments
group_scale

DONE

The step is supossed to do nothing for NIRISS/SOSS (here, a group = 1 frame). Indeed, nothing changes when running this step, except for the length of the ASDF element in the HDU list object, which is normal.

DONE

This step runs well with run command, but produces an error with .call:

Error determining best reference for 'pars-groupscalestep'  =   Unknown reference type 'pars-groupscalestep'

 
N/A

TODO


dq_init

DONE

This step correctly initializes the data-quality flags, as it is supposed to do, according to the reference mask in CRDS.

DONE


DONE


TODO


saturation

DONE

This step does what is expected to do: it captures saturated pixels and flags them in the GROUPDQ masks. The simulations used for this validation had saturated pixels and they were correctly identified (flagged) by the pipeline.

DONE


DONE

done for imager. only high level check for LRS.

TODO


superbias

DONE

Tested my own bias substraction using reference files and got exact same results.

DONE


N/A

TODO


resetN/A
N/A

DONE

This was tested on a TSO imaging file separately since this step does not currently run by default. The test passed with no issues.N/A
linearity

DONE

Tested linearity correction using reference files and got exact same results.

DONE


DONE

sufficiently covered by unit testing. 

TODO


rscdN/A
N/A

DONE

Step currently flags frames in integrations higher than the first as 'DO_NOT_USE' in the groupdq array. This has been tested successfully.N/A
dark_current

DONE

Dark frames perform expected corrections on the data.

DONE


DONE

sufficiently covered by unit testing

TODO


refpix

DONE

Currently, does not do anything to NIRISS/SOSS simulations, as reference pixels there are set to zero. When injecting a fake strain of reference pixels got some deviations that most likely have to do with DMS-detector frame rotations.

DONE


DONE

This step is sufficiently tested in unit tests. It is skipped for MIRI subarray data so only applies to FULL array imaging TSOs, and note that MIRISim's implementation of Refpix is different from the pipeline step, so may give unexpected results. 

TODO



jump

DONE

Step produced no errors. However, currently detecting more jumps than it should — will revisit once some errors on the SOSS simulator are addressed (see below).

DONE

Runs without a crash, but identifies too many pixels as cosmic rays or bad with the default threshold of 4 sigma. Results improve if the threshold is increased to >50 sigma.

NOTE: This step names files 'jump', i.e. without the root 'step'. This differs to all of the remaining steps in stage 1. 

DONE

high level testing is done. Inserted cosmic rays of varying strengths were detected (based on threshold) and flagged neighboring pixels (based on level above background)

TODO


ramp_fitting

DONE

The pipeline was tested against an OLS ramp fit, and pipeline does exactly as intended.

DONE

produced rateints with 7.5 and independent linear fits; substantial difference in a subset of data.

DONE

Well covered by unit tests. May be a candidate for more detailed testing when time.

TODO


gain_scale

DONE

This step only applies to NIRSpec data. Because no GAINFACT is found in the headers, this step is properly skipped by the pipeline.

DONE


DONE

Documentation states 'This currently only applies to NIRSpec exposures that are read out using a subarray pattern, in which case a gain setting of 2 is used instead of the standard setting of 1.' This step is properly skipped for MIRI data.

TODO











Extended comments by instrument branch:

  • NIRISS: For the jump detection algorithm, the pipeline seems to be detecting a large fraction of jumps (~20% per integration). This is apparently a known issue in other instruments as well, and is due to aggresive parameters in the reference files. These will need to be calibrated with on-sky data.
  • NIRCam
  • MIRI:
  • NIRSpec:

Stage 2: Spectroscopic processing TSO testing

Pipeline stepNIRISS statusNIRISS commentsNIRCam statusNIRCam commentsMIRI statusMIRI commentsNIRSpec statusNIRSpec comments
assign_wcs

DONE

Assign WCS indeed adds information to the ASDF name of the files. Tested that ranges of the WCS information made sense.

DONE


DONE

some loose ends to tie up

TODO


extract_2d

DONE

This step is not supported for NIRISS/SOSS, and indeed running this steps shows the "not-supported" message. Still, saves an output equal to the input.

TODO


TODO


TODO


flat_field

DONE

Flat field is correctly applied to NIRISS/SOSS data. 

TODO


ONGOING


TODO

Build 7.5: Failed current validation test  

passes for NRS2, but fails for NRS1:  

JP-1071 -NIRSpec: flat_field calspec2 step failing validation for FS ALLSLITS, BOTS, and MOS data OPEN

srctype

DONE

As stated in the documentation, TSO always defines SRCTYPE to POINT. The pipeline indeed does this for NIRISS/SOSS TSO data.

TODO


TODO


TODO

Build 7.5:  Logic is not correct, always defaults to POINT, even when provided EXTENDED

JP-1576 - source_type logic in spec2 is not correct for NIRSpec FS and MOS modes OPEN

photom

DONE

Photometric calibration is performed according to the NIRISS reference files.

TODO


TODO


TODO


extract_1d

DONE

This step currently extracts a big chunk of the whole subarray as a spectrum, which produced order overlap, which makes this step produce an unusable product for science right now. An algorithm is in development for this step. For details, see  JP-201 - Getting issue details... STATUS .

TODO


TODO


TODO

Build 7.5:                methodology needs to be vetted by TSOWG

additional comments pending

Extended comments by instrument branch:

  • NIRISS:
  • NIRCam
  • MIRI:
  • NIRSpec:

Stage 2: Image Processing TSO testing

Pipeline stepNIRISS statusNIRISS commentsNIRCam statusNIRCam commentsMIRI statusMIRI commentsNIRSpec statusNIRSpec comments
assign_wcsN/A

TODO


TODO


N/A


flat_field

N/A


TODO


TODO


N/A


photom

N/A


TODO


TODO


N/A


Extended comments by instrument branch:

  • NIRISS:
  • NIRCam
  • MIRI:
  • NIRSpec:

Stage 3: Time-Series Observations (TSO) Processing testing

Pipeline stepNIRISS statusNIRISS commentsNIRCam statusNIRCam commentsMIRI statusMIRI commentsNIRSpec statusNIRSpec comments
outlier_detection

DONE

Testing and validation done. Found some problems both with the documentation ( JP-1647 - Getting issue details... STATUS ) and with the effectiveness of the algorithm itself. On this latter point, the algorithm marks as outliers points that are predominantly on the edges of the SOSS profile ( JP-1654 - Getting issue details... STATUS ). The algorithm also doesn't use time-series information at all, and only uses the median image to catch outliers ( JP-1655 - Getting issue details... STATUS ). In my opinion, algorithm currently not optimal for NIRISS/SOSS TSOs at least.

TODO


TODO


TODO


tso_photometry

N/A


TODO


TODO


TODO


extract_1d

DONE

This step currently extracts a big chunk of the whole subarray as a spectrum, which produced order overlap, which makes this step produce an unusable product for science right now. An algorithm is in development for this step. For details, see  JP-201 - Getting issue details... STATUS .

TODO


TODO


TODO


white_light

TODO


TODO


TODO


TODO


Extended comments by instrument branch:

  • NIRISS:
  • NIRCam
  • MIRI:
  • NIRSpec:


  • No labels